Attention is currently required from: Furquan Shaikh, Rizwan Qureshi, Sridhar Siricilla, Aseda Aboagye, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57295 )
Change subject: soc/intel/common/cse: Add argument to send message to appropriate fixed client ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57295/comment/957449f9_043624cf PS4, Line 7: soc/intel/common/cse: Add argument to send message to appropriate fixed client : : There are multiple HECI clients in the CSE. Currently coreboot is sending : HECI messages to only the MKHI client. Add an argument to heci_send_receive() : funtion to provide flexibility to the caller to select the client for which the : message is intended. : : In the follow-up patches there will be messages sent to one other client. Reflow for 72 characters wide
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/57295/comment/7905cbcf_1be51393 PS4, Line 36: /* This is sent to the MEI client endpoint, not the MKHI endpoint */ : int ret = heci_send(&msg, sizeof(msg), BIOS_HOST_ADDR, HECI_MEI_ADDR); : if (!ret) { : printk(BIOS_ERR, "HECI: Failed to send MEI bus disable command!\n"); : return false; : } : : size_t reply_sz = sizeof(reply); : if (!heci_receive(&reply, &reply_sz)) { : printk(BIOS_ERR, "HECI: Failed to receive a reply from CSE\n"); : return false; : } Could adapt this to use the heci_send_receive function now