Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42905 )
Change subject: mb/google/volteer: Add support for passive USB-C daughterboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... PS1, Line 159: device generic 1 on : probe DB_USB USB4_GEN2 : probe DB_USB USB3_ACTIVE : probe DB_USB USB4_GEN3 : probe DB_USB USB3_NO_A : end : end : chip drivers/intel/pmc_mux/con : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU & HSL follow CC : device generic 1 on : probe DB_USB USB3_PASSIVE : end
Hmm, this might start to get a little repetitive (having to re-declare each device)... […]
i'm open to suggestions - don't you then have to walk the device tree and "fix" the sbu_orientation? some simple declarative duplication at this level seems preferable to actual code.
also, from what i've seen so far, most variants have fixed configurations for audio and usb, so the need for "probe" may be very limited.