Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@274 PS1, Line 274: /* Write ACPI VFCT only for Discrete VGA. */ looking at the kernel source: https://github.com/torvalds/linux/blob/6f0d349d922ba44e4348a17a78ea51b713596... The VFCT should be used for the iGPU in dual graphics systems, or the main GPU in single graphics systems.
For dual-graphics dGPU there's the "ATRM" method, which seems to be similar to _ROM, which is already implemented (below this function).