Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37290 )
Change subject: amd/{AGESA,binaryPI}/ramtop: use BIOSRAM to save and restore cbmem top ......................................................................
Patch Set 8:
(1 comment)
squash with CB:37330, move CB:37328 before this
The three implementations of backup/restore probably became identical with those in amd/stoneyridge,picasso. So the logical followup is to have one common implementation in amd/common/block.
The platform still has full control of what value exactly is stored.
https://review.coreboot.org/c/coreboot/+/37290/8/src/northbridge/amd/pi/ramt... File src/northbridge/amd/pi/ramtop.c:
https://review.coreboot.org/c/coreboot/+/37290/8/src/northbridge/amd/pi/ramt... PS8, Line 21: #define BIOSRAM_CBMEM_TOP 0xf0 /* 4 bytes */ These offsets should not be split across several files. Sharing the map with amd/stoneyridge would be ideal. I have no idea why they chose to start filling the space from the end.