Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32887 )
Change subject: Makefile: Turn off SSE instructions for x86_32 architecture
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32887/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32887/2//COMMIT_MSG@18
PS2, Line 18: code
: code
Clang compiled coreboot fails at this point with both qemu-system-x86_64 and qemu-system-i386. […]
Please try that Clang build with SSE=y in .config. (Modify Kconfig as suggested above and do a clean build). Certain SSE opcodes requires C stack aligned to 16 bytes, and qemu-x86/cache_as_ram_bootblock.S call to bootblock_c_entry_bist() does not look right to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9e86900004a285e9a21a300894624b128e6b4d0
Gerrit-Change-Number: 32887
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 22 May 2019 04:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Alan Green
avg@google.com
Gerrit-MessageType: comment