Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38826 )
Change subject: mb/google/hatch: Create nightfury variant
......................................................................
Patch Set 40:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/nightfury/memory.c:
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch...
PS38, Line 4: 2018
Actually it's 2020.
Done
https://review.coreboot.org/c/coreboot/+/38826/38/src/mainboard/google/hatch...
PS38, Line 4: (C)
Does this (C) conform to the template?
I'm not sure. This is a copy from the kohaku variant. But we can modify it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If08692f4a2d216c57499098cc0e35abd708d99d4
Gerrit-Change-Number: 38826
Gerrit-PatchSet: 40
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 05 Mar 2020 09:08:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Bob Moragues
moragues@google.com
Gerrit-MessageType: comment