Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47417 )
Change subject: mb/google/hatch: Configure IRQs as level triggered for HID over I2C ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... PS2, Line 182: PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, NONE),
Hm, how does that differ from volteer for example? […]
Reading the comment in src/soc/intel/common/block/gpio/gpio.c:gpio_configure_itss() the GPI needs to be set to _LOW as well, since the "ITSS takes only active high interrupt signals" (while the touchpad issues an active-low interrupt).
from src/soc/intel/common/block/gpio/gpio.c: 224 /* Set up ITSS polarity if pad is routed to APIC. 225 * 226 * The ITSS takes only active high interrupt signals. Therefore, 227 * if the pad configuration indicates an inversion assume the 228 * intent is for the ITSS polarity. Before forwarding on the 229 * request to the APIC there's an inversion setting for how the 230 * signal is forwarded to the APIC. Honor the inversion setting 231 * in the GPIO pad configuration so that a hardware active low 232 * signal looks that way to the APIC (double inversion). 233 */ 234 if (!(cfg->pad_config[0] & PAD_CFG0_ROUTE_IOAPIC)) 235 return;