Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: add function to detect defeatured SKU
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti...
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti...
PS1, Line 214: ||
nope, this needs to be an or; this is to catch the defeatured-PCO Dali SKUs
Ack, looks like either condition results in less lanes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9eb57595da6f806305552128b0c077ceeb7c4661
Gerrit-Change-Number: 42833
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 16:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment