Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38350 )
Change subject: soc/intel/broadwell: Don't use _ADR and _HID
......................................................................
Patch Set 8:
If anyone disagrees with these patches,
I do. It leaves the tree in an inconsistent state. Nothing changed
since this was reverted. We have discussed this in depth about three
times already. Many alternatives were proposed. IIRC, we even agreed
that the lynxpoint/broadwell code around _ADR (sio_acpi_mod = 0) can
be removed altogether.
I've also proposed to disable the warning (imho, it doesn't provide
any value, just a huge waste of time). Nobody liked that, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e892c451ee9d4e576b568f7efaad2e390524fe0
Gerrit-Change-Number: 38350
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 09 Feb 2020 21:57:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment