Attention is currently required from: Jeff Daly, Vanessa Eusebio.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82242?usp=email )
Change subject: mb/google/poppy: Use <spd.h>
......................................................................
Patch Set 9: -Code-Review
(1 comment)
File src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/82242/comment/73a2e878_36ae7760?usp... :
PS9, Line 28: enum spd_memory_type type;
sounds wrong
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82242?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id07a09b1be83682a44d85da15cd2c0787ad9beb1
Gerrit-Change-Number: 82242
Gerrit-PatchSet: 9
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 15:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr