[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: Add support for long mode

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35681 )

Change subject: cpu/x86/smm: Add support for long mode
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35681/5/src/cpu/x86/smm/smmhandler.... 
File src/cpu/x86/smm/smmhandler.S:

https://review.coreboot.org/c/coreboot/+/35681/5/src/cpu/x86/smm/smmhandler.... 
PS5, Line 219: /* Disable paging */
             : 	movl	%cr0, %eax
             : 	andl	$0x7FFFFFFF, %eax
             : 	movl	%eax, %cr0
> Isn't this covered by the savestate?

yes, just standard long mode disable sequence.

https://review.coreboot.org/c/coreboot/+/35681/5/src/cpu/x86/smm/smmhandler.... 
PS5, Line 229: 
             : 	/* Disable PAE */
             : 	movl	%cr4, %eax
             : 	andl	$(~0x20), %eax
             : 	movl	%eax, %cr4
> Isn't this covered by the savestate?

yes, just standard long mode disable sequence.