Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40694 )
Change subject: soc/intel/apl: Add panel power and backlight configuration
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr...
File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/40694/1/src/soc/intel/apollolake/gr...
PS1, Line 40: i
Reading the signature, I do not know, whatr *i* is supposed to be. […]
Hmmm, written out, it's `index`. But that's what `i` almost always means...
`panel` or even `panel_index`, hmmm or `panel_idx`? idk.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8892ac7aafce1006831e2d9f2806919f5950756
Gerrit-Change-Number: 40694
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wolfgang Kamp
wmkamp@datakamp.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 18:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment