Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40403 )
Change subject: src/mainboard: Make eMMC for UP2 with EDK2 ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40403/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40403/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard: Fix eMMC for UP2 with EDK2
mb/up/squared: Make eMMC work with EDK2
Ack
https://review.coreboot.org/c/coreboot/+/40403/1//COMMIT_MSG@9 PS1, Line 9: maximal
maximum
Ack
https://review.coreboot.org/c/coreboot/+/40403/1//COMMIT_MSG@10 PS1, Line 10: found out that with
Should be on the next line
Ack
https://review.coreboot.org/c/coreboot/+/40403/1//COMMIT_MSG@10 PS1, Line 10: i
spurious `i`
Ack
https://review.coreboot.org/c/coreboot/+/40403/1/src/mainboard/up/squared/de... File src/mainboard/up/squared/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40403/1/src/mainboard/up/squared/de... PS1, Line 20: (
Add a space before the parenthesis?
This was copied from another devicetree.cb and is basically the way of writing in the FSP header documentation for Apollolake, if I recall correctly.