Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: Support for adding camera power resource
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41624/4/src/drivers/intel/mipi_came...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41624/4/src/drivers/intel/mipi_came...
PS4, Line 383: if (seq->ops[i].action == ENABLE) {
: method_params[0] = config->gp_panel.gps[index].gp_num;
: acpigen_call_method("STXS", method_params, 1);
: } else if (seq->ops[i].action == DISABLE) {
: method_params[0] = config->gp_panel.gps[index].gp_num;
: acpigen_call_method("CTXS", method_params, 1);
: } else {
There are already functions that implement this logic on a per-SoC basis. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31e198b50acf2c64035aff9cb054fbe3602dd83e
Gerrit-Change-Number: 41624
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Comment-Date: Thu, 04 Jun 2020 19:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment