Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35620 )
Change subject: soc/intel/skylake/chip: Unhide P2SB device
......................................................................
Patch Set 3: Code-Review+1
Patch Set 3:
Patch Set 3: Code-Review+2
while this fixes the "BUG" warnings for P2SB, there are still others for calls accessing 13.0, 08.0, and 1e.0 on a Librem 13v2 SKL device (and other SKL/KBL devices I'd assume) which need to be addressed as well
Matt,
I don't see entries in the devicetree for those devices:
src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb
src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb
Are there other mainboards you re seeing this on? And what was the exact warning?
This is another bug but not related to p2sb. I vote for merging this and working on the other warnings independent, as we already have multiple +2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d14646098c34d3bf5cd49c35dcfcdce2c57431d
Gerrit-Change-Number: 35620
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 08 Oct 2019 19:01:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment