8 Jul
2021
8 Jul
'21
7:02 p.m.
Attention is currently required from: Daniel Kurtz, Martin Roth, Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56100 )
Change subject: grunt/treeya: add Realtek ALC5682 codec support ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/kahlee/variants/treeya/audio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123650): https://review.coreboot.org/c/coreboot/+/56100/comment/589d72d3_a0fd4547 PS4, Line 25: if (mmio_dev == NULL){ space required before the open brace '{'
--
To view, visit https://review.coreboot.org/c/coreboot/+/56100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49c673fd944b2c2a79c4283eee941a16596ba7fa
Gerrit-Change-Number: 56100
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com
Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Daniel Kurtz djkurtz@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 08 Jul 2021 17:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment