Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40523 )
Change subject: soc/xeon_sp: Read PPIN MSR and save to an array for each CPU
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40523/5/src/soc/intel/xeon_sp/skx/c...
File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/40523/5/src/soc/intel/xeon_sp/skx/c...
PS5, Line 75: /* If socket_index is 0 then all PPIN have been saved. */
I wonder if this logic is over complicated. We want to read PPIN MSR from one core/thread of each socket. So we can just read PPIN MSR of core 0, thread 0 of each socket (or PBSP, SBSP).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1de8bcb651fb8ae8b106db1978235b0dd84c47
Gerrit-Change-Number: 40523
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment