Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46041 )
Change subject: soc/amd/picasso: Remove xhci0_force_gen1 from soc config
......................................................................
Patch Set 1:
(2 comments)
Some people would probably ask you to split this into two patches - one for the mainboard and another for the chipset changes. Personally, I don't think that's needed as it's just the removal of code that's no longer needed, but I'll leave that up to you.
https://review.coreboot.org/c/coreboot/+/46041/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46041/1//COMMIT_MSG@9
PS1, Line 9: remvoe
remove
https://review.coreboot.org/c/coreboot/+/46041/1//COMMIT_MSG@11
PS1, Line 11: custmzied
customize
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5f0c1f22d8c98c4461f09d074bf082c340b14d9
Gerrit-Change-Number: 46041
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 06 Oct 2020 19:29:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment