Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/33433/9/src/mainboard/facebook/fbg1701/ramst... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/#/c/33433/9/src/mainboard/facebook/fbg1701/ramst... PS9, Line 326: static const struct edp_data_t *edptable; No need for 'static' here.
https://review.coreboot.org/#/c/33433/9/src/mainboard/facebook/fbg1701/ramst... PS9, Line 329: CPLD_PCB_VERSION_BIT) < 7) Maybe you want to log with BIOS_DEBUG or BIOS_INFO the detected CPLD version?
https://review.coreboot.org/#/c/33433/9/src/mainboard/facebook/fbg1701/ramst... PS9, Line 342: (u8 *)&edptable->data[0]) < 0) Display will not be functional, log error with BIOS_ERR (or even higher). IMHO you should do a couple retries, but I leave it up to you to decide.