[coreboot-gerrit] Change in coreboot[master]: arch/x86: Fix S3 resume without stage cache

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37683 )

Change subject: arch/x86: Fix S3 resume without stage cache
......................................................................

Patch Set 9:
> Patch Set 9:
> > Patch Set 9:
> > > Patch Set 9:
> > >
> > > Starting from scratch (no `.config`), `make menuconfig` shows this prompt under *General setup*. Is that intended?
> >
> > I don't have ideas how to improve it from this without implementing TSEG on AGESA and removing CBMEM_STAGE_CACHE.
>
> Should it be user selectable, or could the prompt be hidden?

I think it should be user selectable: i.e - if I remember correctly - there's a boot failure on AMD boards if CBMEM_STAGE_CACHE is enabled while a SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT is also enabled. Since SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT is user selectable, CBMEM_STAGE_CACHE should be too.