Attention is currently required from: Felix Singer, Nico Huber, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52789 )
Change subject: soc/intel/skylake: Drop EXCLUDE_NATIVE_SD_INTERFACE
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Can somebody check why this was added? CB:12946, BUG=chrome-os-partner:48190 […]
On some devices the native SD controller was not utilized. A USB-to-SD controller was used instead. Reading through the bug, it seems the intent was to drop the code needing to interact with the device as it was expected to be turned off.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id07f59b5252cf3862724d6ff3d7c54d51ccfd9a6
Gerrit-Change-Number: 52789
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 03 May 2021 16:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment