Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36455 )
Change subject: soc/intel/{apl,cnl,dnv,icl,skl}: Move lpc.asl into common/block/acpi
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36455/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36455/3//COMMIT_MSG@14
PS3, Line 14: rather
rather than
https://review.coreboot.org/c/coreboot/+/36455/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/lpc.asl:
https://review.coreboot.org/c/coreboot/+/36455/3/src/soc/intel/common/block/...
PS3, Line 4: * Copyright (C) 2007-2009 coresystems GmbH
IANAL but I don't think it is legit to remove these […]
I'd leave the previous copyright lines because AUTHORS is not complete yet. Also, given the rather high similarity index, I would say dropping copyright lines is not a good idea.
IANAL either, so I would play safe: how about keeping the previous copyright years, and updating the years for Intel Corporation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36455
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I266d6e667e7ae794377e4882791e3be933d35e87
Gerrit-Change-Number: 36455
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 31 Oct 2019 14:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment