You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31564
Change subject: libpayload: cbfs: Check decompressed size when loading files. ......................................................................
libpayload: cbfs: Check decompressed size when loading files.
After loading compressed files in CBFS, we should check the decompressed size is equal to the expected size. This might help us detect file content corruption or compressor/decompressor bugs.
BUG=none BRANCH=none TEST=boot into kernel on kukui
Change-Id: Ia756cc5477670dd0d1d8aa59d4160ab4233c6795 Signed-off-by: You-Cheng Syu youcheng@google.com --- M payloads/libpayload/libcbfs/cbfs_core.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/31564/1
diff --git a/payloads/libpayload/libcbfs/cbfs_core.c b/payloads/libpayload/libcbfs/cbfs_core.c index 91f2603..e234214 100644 --- a/payloads/libpayload/libcbfs/cbfs_core.c +++ b/payloads/libpayload/libcbfs/cbfs_core.c @@ -256,7 +256,7 @@ return NULL;
ret = malloc(*size); - if (ret != NULL && !cbfs_decompress(algo, data, ret, *size)) { + if (ret != NULL && cbfs_decompress(algo, data, ret, *size) != *size) { free(ret); ret = NULL; }