Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: [WIP]payloads/tianocore: Enable UEFIPayload
......................................................................
Patch Set 1:
Patch Set 1:
I've not had a chance to boot-test this patch yet, but it is insufficient as-is with a default config due to the default being my repo/my coreboot_fb branch. One would need to change the git revision to upstream/master for this to build even.
Until UefiPayloadPkg reaches feature/functional parity with my existing fork, what might make sense is to add a Kconfig option to select CorebootPayloadPkg (using my repo/branch) or UefiPayloadPkg (using upstream/master) and leave the default as-is
I tested a separately build UefiPayloadPkg (qemu). Specifying the PCIE_BASE was needed and PS2 keyboard did not work. Other than that, it does boot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7785fde9f4113b2cd91323ac0358b229c5a6e6
Gerrit-Change-Number: 34459
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 21 Jul 2019 16:48:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment