Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35645 )
Change subject: vboot: Fix wrong algorithm in TCPA log for BOOT_MODE ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35645/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35645/2//COMMIT_MSG@9 PS2, Line 9: The hash algorithm for VBOOTs BOOT_MODE is fixed to sha1 but TCPA log I don't think this is the case any more. Does the coreboot.org vboot submodule need to be updated? Or is it the fact that tlcl_extend assumes a specific digest algo? Is that TCG defined?
https://review.coreboot.org/c/coreboot/+/35645/2//COMMIT_MSG@13 PS2, Line 13: BOOT_MODE. I'm confused. TCPA log uses sha256 as the name, but how is it getting the size? In tpm_extend_pcr the digest_algo is passed into tcpa_log_add_table_entry().