View Change
2 comments:
Commit Message:
Patch Set #2, Line 9: The hash algorithm for VBOOTs BOOT_MODE is fixed to sha1 but TCPA log
I don't think this is the case any more. Does the coreboot.org vboot submodule need to be updated? Or is it the fact that tlcl_extend assumes a specific digest algo? Is that TCG defined?
Patch Set #2, Line 13: BOOT_MODE.
I'm confused. TCPA log uses sha256 as the name, but how is it getting the size? In tpm_extend_pcr the digest_algo is passed into tcpa_log_add_table_entry().
To view, visit change 35645. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia25938ac5f6c29f60a4819023b99f7796849f574
Gerrit-Change-Number: 35645
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Andrey Pronin <apronin@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 27 Sep 2019 14:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment