Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: sb/intel/bd82x6x: Support ME Soft Temporary Disable Mode
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37115/11/src/southbridge/intel/bd82...
File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/11/src/southbridge/intel/bd82...
PS11, Line 574: for (i = 0; i < 400; i++) {
: mdelay(50);
: pci_read_dword_ptr(dev, &hfs, PCI_ME_HFS);
: printk(BIOS_SPEW, "ME: hfs.fw_init_complete=%d after %dms\n",
: hfs.fw_init_complete, (i+1)*50);
:
: if (hfs.fw_init_complete)
: break;
: }
:
: if (!hfs.fw_init_complete)
: printk(BIOS_ERR, "ME: giving up on waiting for fw_init_complete\n");
Please use the stopwatch framework, and print the total time in the end.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic01526c9731cbef4e8552bbc352133a2415787c2
Gerrit-Change-Number: 37115
Gerrit-PatchSet: 14
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 03:47:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment