build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Signed-off-by: Maccraft123 maccraft123mc@gmail.com Change-Id: I4a722382c6f3207388eb27bcc97561609e0de1dd ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... File src/mainboard/lenovo/r60/dock.c:
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... PS1, Line 92: while(!(dlpc_read_register(0x29) & 0x10) && timeout--) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... PS1, Line 119: while(!(dock_read_register(0x29) & 0x10) && timeout--) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... PS1, Line 188: while(!(inb(DLPC_CONTROL) & 8) && timeout--) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... PS1, Line 203: udelay(10000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/do... PS1, Line 230: udelay(100000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/mp... File src/mainboard/lenovo/r60/mptable.c:
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/mp... PS1, Line 42: smp_write_intsrc(mc, mp_ExtINT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, isa_bus, 0x00, MP_APIC_ALL, 0x00); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/mp... PS1, Line 43: smp_write_intsrc(mc, mp_NMI, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, isa_bus, 0x00, MP_APIC_ALL, 0x01); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/ro... File src/mainboard/lenovo/r60/romstage.c:
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/ro... PS1, Line 63: while(!(pnp_read_config(dev, 0x29) & 0x10) && timeout--) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... File src/mainboard/lenovo/r60/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 41: if ((bar = (u8 *)pci_read_config32(PCI_DEV(1, 0, 0), 0x18))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 42: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 52: if ((bar = (u8 *)pci_read_config32(PCI_DEV(1, 0, 0), 0x18))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 53: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 123: switch (event) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35293/1/src/mainboard/lenovo/r60/sm... PS1, Line 157: switch (data) { switch and case should be at the same indent