Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG@7
PS2, Line 7: mb/google/deltaur: Support to enable GbE
Enable GbE
Done
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau...
PS2, Line 3: #PCIe
Please add a space after #.
Done
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau...
PS2, Line 8: device pci 1f.6 on end # GbE 0x15E1/0x15E2/0x15FC
Less tabs for alignment could be used.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c36b132546049e3e775585c41164072f4ece73e
Gerrit-Change-Number: 40001
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 15:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment