Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37705 )
Change subject: mainboard/intel/common: Add config for intel common mainboard support ......................................................................
Patch Set 6:
Patch Set 6:
Note that this is just an idea. Before implementing anything, I would bring this up on the mailing list so that we can all brainstorm and choose the best approach.
Aamir, Can you please initiate a discussion regarding this in the coreboot mailing list?
Also until the discussion is going on in the mailing list, is it ok to continue with the old way of doing things i.e. continue development in the relevant mainboard?
Problems mostly arise when we start to fork unnecessary copies of sources. In my opinion you can do development within one mainboard and identify in the Makefile what parts you consider should go into shared location instead.
Consider that board as a proof-of-concept. Depending of how the discussion mailing list goes you get either a quick solution and agreement, or plethora of different opinions.
Personally I don't like cases where common code has dependency of headerfiles located under platform directories. Like <soc/pci_devs.h>. You may want to specifically ask if such approach like <mb/board-specific.h> should be avoided.