Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48257 )
Change subject: soc/intel/common/dmi: Move DMI defines into DMI driver header ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48257/1/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/48257/1/src/soc/intel/tigerlake/boo... PS1, Line 39: #define PCR_DMI_DMICTL 0x2234 : #define PCR_DMI_DMICTL_SRLOCK (1 << 31) This will have to be removed from pch.c for all Intel SoCs.
https://review.coreboot.org/c/coreboot/+/48257/1/src/soc/intel/tigerlake/boo... PS1, Line 105: pch_check_decode_enable Maybe in a follow-up change, but I think we should add a helper for this as well since it seems to be used by all SoCs.
dmi_check_srlock()