Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34423 )
Change subject: soc/amd/picasso: Add FSP support for including AGESA ......................................................................
Patch Set 16:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG@11 PS2, Line 11: e.g. in EDK II,
All this entire paragraph is doing is establishing a premise. […]
Done
https://review.coreboot.org/c/coreboot/+/34423/2//COMMIT_MSG@12 PS2, Line 12: legacy BIOS
What do you mean by “legacy BIOS”? […]
Done
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/reset.c File src/soc/amd/picasso/reset.c:
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/reset.c... PS2, Line 70: die("unknown reset type");
Sure. […]
Done
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/romstag... File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/34423/2/src/soc/amd/picasso/romstag... PS2, Line 148: todo: verify TOM < UMA region when UMA is below 4GB
Will file a bug due to uncertainty of when we'll be able to test it by moving UMA.
OBE. Using HOBs now instead of assuming we can rely on TOM.