Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33933 )
Change subject: soc/intel/icelake: Disable HDA based on devicetree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33933/3/src/soc/intel/icelake/romst...
File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/33933/3/src/soc/intel/icelake/romst...
PS3, Line 41: pcidev_on_root(0x1f, 3);
nit: If you use pcidev_path_on_root you can specify PCH_DEVFN_HDA as argument instead of having to put in slot and function number as arguments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28c2beca4bc26ddb896e68886571ebdc82276b48
Gerrit-Change-Number: 33933
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 03 Jul 2019 19:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment