Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar() ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34808/6/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/6/src/cpu/intel/car/romstage.... PS6, Line 25: static struct postcar_frame early_mtrrs; FWIW, this doesn't need to be in .bss since there's a single execution path where the object could sit on the stack w/o going out of scope.
https://review.coreboot.org/c/coreboot/+/34808/6/src/include/cpu/intel/romst... File src/include/cpu/intel/romstage.h:
https://review.coreboot.org/c/coreboot/+/34808/6/src/include/cpu/intel/romst... PS6, Line 8: void fill_postcar_frame(struct postcar_frame *pcf); Add a comment here w.r.t. when it's called and what the implementer should do?