20 Nov
2020
20 Nov
'20
11:36 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41120 )
Change subject: cbfs: Add verification for RO CBFS metadata hash ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41120/10/src/include/cbfs_glue.h File src/include/cbfs_glue.h:
https://review.coreboot.org/c/coreboot/+/41120/10/src/include/cbfs_glue.h@10 PS10, Line 10: #define CBFS_ENABLE_HASHING (CONFIG(CBFS_VERIFICATION) && \
Could you please add a comment covering the conditions and reasoning? i.e. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/41120
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8930434de55eb938b042fdada9aa90218c0b5a34
Gerrit-Change-Number: 41120
Gerrit-PatchSet: 14
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Nov 2020 23:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Gerrit-MessageType: comment