build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42712 )
Change subject: security/intel/txt: Add Intel TXT support ......................................................................
Patch Set 3:
(18 comments)
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... File src/security/intel/txt/common.c:
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 146: const struct acm_header_v0 *acm_header = (struct acm_header_v0*)ptr; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 157: const struct acm_header_v0 *acm_header = (struct acm_header_v0*)ptr; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 163: /* Seems inconsistent accross generations. */ 'accross' may be misspelled - perhaps 'across'?
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 390: printk(BIOS_DEBUG, "TEE-TXT: GETSEC[CAPABILITIES] returned: \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 392: if (eax & (1 << 0)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 399: if (eax & (1 << 2)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 406: if (eax & (1 << 3)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 413: if (eax & (1 << 4)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 420: if (eax & (1 << 5)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 427: if (eax & (1 << 6)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/comm... PS3, Line 476: if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/gets... File src/security/intel/txt/getsec.c:
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/gets... PS3, Line 79: for(i = 0; i < 0x1f; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... File src/security/intel/txt/logging.c:
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... PS3, Line 40: printk(BIOS_ERR, "%s: Error occured\n", phase); 'occured' may be misspelled - perhaps 'occurred'?
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... PS3, Line 49: switch(txt_error & TXT_ERROR_MASK) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... PS3, Line 165: switch(acm_header->flags) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... PS3, Line 165: switch(acm_header->flags) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/logg... PS3, Line 182: switch (acm_header->size) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/rams... File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/42712/3/src/security/intel/txt/rams... PS3, Line 53: for (; mseg_base < mseg_size; mseg_base++) { braces {} are not necessary for single statement blocks