Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )
Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>' ......................................................................
Patch Set 4:
Isn't <commonlib/helpers.h> chain-included via <types.h>? I think that should be enough. We shouldn't need to encode every detail of where common utility stuff comes from (which changes on occasion) in every file.
it is included via <stddef.h>. the idea is to set <stddef.h> providing only standards. maybe it is a bad idea, at least, it needs a lot of work and time for review.
Alternatively, move the `helpers.h` include into `types.h`? That should properly reflect the intentions:
1. `stddef.h` only provides standard functions, 2. `types.h` gathers several includes for convenience.