Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32548 )
Change subject: spd_bin: Do not depend CONFIG_DIMM_MAX on CONFIG_GENERIC_SPD_BIN
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32548/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32548/2//COMMIT_MSG@10
PS2, Line 10: platforms that use code from lib/spd_bin.c without
: enabling CONFIG_GENERIC_SPD_BIN
Probably it should have been part of this change: https://review.coreboot.org/c/coreboot/+/18265/4/src/lib/Makefile.inc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I041c52b6bd255e9a9920e5a101165ba5fc5fa6f3
Gerrit-Change-Number: 32548
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 May 2019 15:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment