Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49050 )
Change subject: drivers/vpd: Add support to read device serial from VPD ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49050/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49050/3//COMMIT_MSG@10 PS3, Line 10: Select by default when VPD driver selected. This sentence is odd. Select what? It also goes beyond the 72-char limit.
https://review.coreboot.org/c/coreboot/+/49050/3/src/drivers/vpd/Kconfig File src/drivers/vpd/Kconfig:
https://review.coreboot.org/c/coreboot/+/49050/3/src/drivers/vpd/Kconfig@26 PS3, Line 26: default y if !CHROMEOS What's the point of adding this default? I feel it unnecessarily makes things more complex.