Attention is currently required from: Sridhar Siricilla, Arthur Heymans, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )
Change subject: soc/intel/alderlake, soc/common: Add method to determine the cpu type ......................................................................
Patch Set 6:
(4 comments)
Patchset:
PS6: Hmm, we haven't made it very easy to get data out of MP Init, have we....
unless we feel like solving that problem here... maybe this would be better off if it is 1 whole procedure that invokes `mp_run_on_all_cpus()` instead and returns/fills an array of core types for each core in the system ?
WDYT?
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/59360/comment/eacd16c2_e30cd7e3 PS6, Line 15: uint8_t `enum core_type`
https://review.coreboot.org/c/coreboot/+/59360/comment/29c2bb09_ce3f2f5a PS6, Line 15: uint8_t __weak get_soc_cpu_type(void) : { : return 0; : } Should not be necessary to add this weak function, instead let's just make it mandatory for platforms that select `CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_CPU_HYBRID` to implement `get_soc_cpu_type`, but first that needs to have a more well-defined return type like below.
File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/59360/comment/452e71ec_45119837 PS6, Line 17: Since this can return incorrect data before MP-init, then this should have an 'INVALID' or 'UNKNOWN' or similar value as well.