Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87213?usp=email )
Change subject: mb/starlabs/starbook/tgl: Change SSD Enable GPIO to PLTRST ......................................................................
mb/starlabs/starbook/tgl: Change SSD Enable GPIO to PLTRST
Change the SSD Enable GPIO to PLTRST, as having it configure to DEEP, renders the SSD inaccessible on S3 exit as it conflicts with the RTD3 driver.
Change-Id: If4a406af13005ba4532091d0c5c75f5198e04ff4 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87213 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/variants/tgl/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index b6f1526..2794ea4 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -42,7 +42,7 @@ /* SSD */ PAD_NC(GPP_D8, NONE), /* Clock Request 3 */ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* Reset */ - PAD_CFG_GPO(GPP_D16, 1, DEEP), /* Enable */ + PAD_CFG_GPO(GPP_D16, 1, PLTRST), /* Enable */
/* SATA */ PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* PEDET */