Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39810 )
Change subject: memranges: Change align attribute to be log2 of required alignment ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h File src/include/memrange.h:
https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h@116 PS2, Line 116: log2(4 * KiB) We could just use '12'. I'm not sure if the compiler is constant folding or this turns into a runtime check.
https://review.coreboot.org/c/coreboot/+/39810/2/src/lib/memrange.c File src/lib/memrange.c:
https://review.coreboot.org/c/coreboot/+/39810/2/src/lib/memrange.c@236 PS2, Line 236: 1 1ULL throughout as resource_t is a 64-bit value.