Attention is currently required from: Mario Scheithauer, Angel Pons, Lean Sheng Tan, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )
Change subject: soc/intel/ehl: Add EHL MDIO operation
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/elkhartlake/mdio.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/d8481af4_9e3b853a
PS7, Line 82: .read_resources = noop_read_resources,
: .set_resources = noop_set_resources,
This will override the PCI device_operations? Would it make sense to export mdio_ops (give it better name like ehl_mdio_ops) and hook it up statically in ehl code instead of setting the full ops pointer at runtime?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d1b9dd2f2ba8c18291fff314c13f0c3851784aa
Gerrit-Change-Number: 69383
Gerrit-PatchSet: 7
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 11:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment