Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd...
File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd...
PS15, Line 17: AGESA
Originally I was told to not enter in details... blame AGESA instead of HW. I would prefer your way. […]
I disagree with a position of placing "blame" on AGESA. What I'm asking for is already public: https://doc.coreboot.org/soc/amd/family17h.html?highlight=family#problem-sta...
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd...
PS15, Line 18: CAR
Add a period to match other bullet items.
https://review.coreboot.org/c/coreboot/+/34662/15/Documentation/binaries/amd...
PS15, Line 47: TBD
Replace with "will be documented separately for each project using the FSP framework". IIRC Intel calls these Integration Guides but they're separate from the EAS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a5d34df93cd0ff647e2ccfdbf8700b4df00a59
Gerrit-Change-Number: 34662
Gerrit-PatchSet: 15
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kerry Brown
kerry.brown@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 03 Oct 2019 03:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment