Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40515 )
Change subject: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40515/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40515/4//COMMIT_MSG@10 PS4, Line 10: any device that is sitting behind the Chrome EC. It accepts a config
With HID GOOG0012?
Done
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... File src/ec/google/chromeec/i2c_tunnel/chip.h:
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 3: *
No blank line? Angel?
Done
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 14: int
unsigned int?
Done
https://review.coreboot.org/c/coreboot/+/40515/4/src/ec/google/chromeec/i2c_... PS4, Line 16: int
unsigned int?
Done