[coreboot-gerrit] Change in coreboot[master]: post_code: replace postcode values with their respective defined cons...

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42503 )

Change subject: post_code: replace postcode values with their respective defined constants
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42503/6/src/cpu/intel/car/non-evict... 
File src/cpu/intel/car/non-evict/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/42503/6/src/cpu/intel/car/non-evict... 
PS6, Line 16: 	post_code(POST_BOOTBLOCK_PRE_C_ENTRY)
Moved. I think this is fine.

https://review.coreboot.org/c/coreboot/+/42503/6/src/cpu/intel/car/non-evict... 
PS6, Line 181: 	post_code(POST_CAR_CACHE_EVICTION)
Moved. This appears to be fine, but you need to keep in mind this changes the value of %eax register.

Here, it is followed by rdmsr which reloads %eax.