Attention is currently required from: Martin L Roth, Subrata Banik, Mario Scheithauer, Angel Pons.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )
Change subject: src/device + util/sconfig: Introduce new device 'mdio'
......................................................................
Patch Set 5:
(1 comment)
File src/include/device/path.h:
https://review.coreboot.org/c/coreboot/+/69382/comment/db6dfb07_08dd5fa9
PS5, Line 117: struct mdio_path {
: unsigned int addr;
: };
Just wondering: What would happen if you added ': 5' bitfield here? Would that somehow have the comp […]
I will give it a try and let you know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6691f92c4233bc30afc9029840b06f74bb1eb4b2
Gerrit-Change-Number: 69382
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 10:10:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment