Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/google/dedede/var/boten: Update devicetree
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede...
PS8, Line 42: [PchSerialIoIndexI2C5] = PchSerialIoPci,
Is I2C5 used? If so, can you please add in the above table regarding the use-case for I2C5 and also […]
As I know, this one will be planed to P-Sensor later.
https://review.coreboot.org/c/coreboot/+/43175/8/src/mainboard/google/dedede...
PS8, Line 52: Right Type-A Port
How many USB-A and USB-C ports? This is overriding the Right Type-C port with Type-A port. […]
I have other comment to suggest them to be amend for LTE usage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c692bd7f997e9a90de646b807c6c1b37a834d2
Gerrit-Change-Number: 43175
Gerrit-PatchSet: 9
Gerrit-Owner: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 08:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment