Attention is currently required from: Tim Wawrzynczak, Julius Werner, Sridhar Siricilla. Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update ......................................................................
Patch Set 13:
(8 comments)
Patchset:
PS11:
Please be aware that the cbfs_locate_file_in_region() API is about to be deprecated (CB:59682) and s […]
Do to urgency of this feature, we would like to update this in a subsequent patch, as it would require more testing.
File src/soc/intel/common/block/cse/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59685/comment/754b5eec_8e56b813 PS11, Line 110:
I think we should hash the IOM and NPHY binaries as well, just like we do for cse_rw
These blobs are part of FW_MAIN_A/FW_MAIN_B/COREBOOT, they are verified by vboot.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/79a56568_a836511d PS11, Line 15: #define BPDT_HEADER_SZ sizeof(struct bpdt_header) : #define BPDT_ENTRY_SZ sizeof(struct bpdt_entry) : #define SUBPART_HEADER_SZ sizeof(struct subpart_hdr) : #define SUBPART_ENTRY_SZ sizeof(struct subpart_entry) : #define SUBPART_MANIFEST_HDR_SZ sizeof(struct subpart_entry_manifest_header)
line up the right sides please
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/3283e37f_bef8c2b6 PS11, Line 768:
nit: remove the extra space
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/b32be1e0_2027f6b7 PS11, Line 810:
nit: extra line
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/b6e0788e_c89d9149 PS11, Line 975: int
`size_t`
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/c2b913b2_ad6cb0f1 PS11, Line 975: 2
`ARRAY_SIZE(cse_regions)`
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/d32050e8_b4b0d603 PS11, Line 976:
nit: extra line
Done