30 Oct
2020
30 Oct
'20
6:55 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46728 )
Change subject: azalia: Use `HDA_GCTL_CRST` macro as unset-mask ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46728/11/src/southbridge/intel/ibex... File src/southbridge/intel/ibexpeak/azalia.c:
https://review.coreboot.org/c/coreboot/+/46728/11/src/southbridge/intel/ibex... PS11, Line 45: set_bits oof, maybe it's just me but set_bits is confusing; what about reworking that to have unset_and_set_bits(reg, unset, set), unset_bits(reg, unset) and set_bits(reg, set) just like we have now for msrs? CB:46354
Nico, wdyt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/46728
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f4455aa1255f8954ac8b5f1ea5cf8f0874f77a4
Gerrit-Change-Number: 46728
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Oct 2020 06:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment